Re: [PATCH] Update the usage bundle string.

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Sep 17, 2009, 06:12 UTC
Message-ID: <4AB1D364.1080701@viscovery.net>
In-Reply-To: <1253136011-12011-1-git-send-email-tfransosi@gmail.com>

Thiago Farina schrieb:

> @@ -11,6 +11,12 @@
>  
>  static const char *bundle_usage="git bundle (create <bundle> <git rev-list args> | verify <bundle> | list-heads <bundle> [refname]... | unbundle <bundle> [refname]... )";

Is this variable still used? Shouldn't it be removed?

Show 5 quoted lines

> +static const char builtin_bundle_usage[] = "\
> +  git bundle create <file> <git-rev-list args>\n\
> +  git bundle verify <file>\n\
> +  git bundle list-heads <file> [refname...]\n\
> +  git bundle unbundle <file> [refname...]";

You indent the usage text. Do other commands do that, too? If you resend, it may be worth using this style:

static const char builtin_bundle_usage[] =
	"git bundle create <file> <git-rev-list args>\n"
	"git bundle verify <file>\n"
...

i.e. not to use backslash-at-eol.

> -	if (argc < 3)
> -		usage(bundle_usage);
> +  if (argc < 3)
> +		usage(builtin_bundle_usage);

This re-indentation is an accident, isn't it?

-- Hannes