git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v4 07/10] introduce fetch-object: fetch one promisor object

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Nov 17, 2017, 20:22 UTC
Message-ID
<a414c170-3eba-e5b9-6235-c6785129097e@ramsayjones.plus.com>
In-Reply-To
<798096fe-dd01-5351-94d3-949039c84e69@jeffhostetler.com>
On 17/11/17 19:49, Jeff Hostetler wrote:
Show 19 quoted lines
> 
> 
> On 11/16/2017 2:57 PM, Ramsay Jones wrote:
>>
>>
>> On 16/11/17 18:12, Jeff Hostetler wrote:
>>> From: Jonathan Tan <jonathantanmy@google.com>
>>>
>>> Introduce fetch-object, providing the ability to fetch one object from a
>>> promisor remote.
> [snip]
>>> +#include "transport.h"
>>
>> I note that this still does not #include "fetch_object.h".
>> [If you recall, this suppresses a sparse warning].
>>
> 
> Sorry, I missed that.  I know I did a DEVELOPER=1 build and
> I didn't see a warning, but I'll check again.

Unless you have sparse installed and 'make sparse' as part of your build, you won't see anything. ;-)

However, ignore sparse for the moment, if you don't #include the header (interface) file in fetch-object.c, you can't expect the compiler to tell you when there is a mismatch between the interface and implementation.

There are some additional sparse warnings associated with these series, ... (hopefully I can find some time tonight)

ATB, Ramsay Jones

Previous: Jeff HostetlerNext: Stefan Beller
Message 9 of 17 in “Partial clone part 2: fsck and promisors”
  1. 00/10 Partial clone part 2: fsck and promisorsJeff Hostetler, Nov 16, 2017
  2. 04/10 fsck: support referenced promisor objectsJeff Hostetler, Nov 16, 2017
  3. 05/10 fsck: support promisor objects as CLI argumentJeff Hostetler, Nov 16, 2017
  4. 03/10 fsck: support refs pointing to promisor objectsJeff Hostetler, Nov 16, 2017
  5. 06/10 index-pack: refactor writing of .keep filesJeff Hostetler, Nov 16, 2017
  6. 07/10 introduce fetch-object: fetch one promisor objectJeff Hostetler, Nov 16, 2017
  7. Ramsay JonesNov 16, 2017
  8. Jeff HostetlerNov 17, 2017
  9. Ramsay JonesNov 17, 2017
  10. Stefan BellerNov 17, 2017
  11. Jeff HostetlerNov 20, 2017
  12. 02/10 fsck: introduce partialclone extensionJeff Hostetler, Nov 16, 2017
  13. 08/10 sha1_file: support lazily fetching missing objectsJeff Hostetler, Nov 16, 2017
  14. 10/10 gc: do not repack promisor packfilesJeff Hostetler, Nov 16, 2017
  15. 09/10 rev-list: support termination at promisor objectsJeff Hostetler, Nov 16, 2017
  16. 01/10 extension.partialclone: introduce partial clone extensionJeff Hostetler, Nov 16, 2017
  17. Jonathan TanNov 16, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.