Re: [PATCH v4 07/10] introduce fetch-object: fetch one promisor object

From: Jeff Hostetler <git@jeffhostetler.com>
Date: Nov 20, 2017, 15:56 UTC
Message-ID: <85b615eb-d152-ed7e-779c-8fc3e46d60e1@jeffhostetler.com>
In-Reply-To: <CAGZ79kZCdxN8h-mJRY9fQy5W3HtqcvFoL1W5jVcb3=A3vvk_Ww@mail.gmail.com>

On 11/17/2017 3:17 PM, Stefan Beller wrote:

Show 31 quoted lines

> On Fri, Nov 17, 2017 at 11:49 AM, Jeff Hostetler <git@jeffhostetler.com> wrote:
>>
>>
>> On 11/16/2017 2:57 PM, Ramsay Jones wrote:
>>>
>>>
>>>
>>> On 16/11/17 18:12, Jeff Hostetler wrote:
>>>>
>>>> From: Jonathan Tan <jonathantanmy@google.com>
>>>>
>>>> Introduce fetch-object, providing the ability to fetch one object from a
>>>> promisor remote.
>>
>> [snip]
>>>>
>>>> +#include "transport.h"
>>>
>>>
>>> I note that this still does not #include "fetch_object.h".
>>> [If you recall, this suppresses a sparse warning].
>>>
>>
>> Sorry, I missed that.  I know I did a DEVELOPER=1 build and
>> I didn't see a warning, but I'll check again.
> 
> sparse is an extra tool, which you have to run/install;
> it is not included in the developer build.
> 
> https://en.wikipedia.org/wiki/Sparse
>

ah, thanks! Jeff