Re: [RFC/PATCH] refs: tone down the dwimmery in refname_match() for {heads,tags,remotes}/*
- From
Paolo Bonzini <pbonzini@redhat.com>
- Date
- May 27, 2019, 15:44 UTC
- Message-ID
- <a40c5388-4274-6bfa-4213-6013601c8fae@redhat.com>
- In-Reply-To
- <xmqqef4jewj6.fsf@gitster-ct.c.googlers.com>
On 27/05/19 17:39, Junio C Hamano wrote:
Show 5 quoted lines
> I do not think lightweight vs annotated should be the issue. The > tag that the requestor asks to be pulled (from repository ../b) > should be what the requestor has locally when writing the request > (in repository .). Even if both tags at remote and local are > annotated, we should still warn if they are different objects, no?
Right, lightweight vs annotated then is the obvious special case where one of the two is a commit and the other is a tag, hence they ought not to have the same SHA1. I'll take a look.
Paolo