Re: [PATCH 1/1] Use GIT_ASKPASS environment to launch thirdpart UI app to get password
- From
- Laszlo Papp <djszapi@archlinux.us>
- Date
- Feb 25, 2010, 17:15 UTC
- Message-ID
- <a362e8011002250915l7e42beel316878b60899c440@mail.gmail.com>
- In-Reply-To
- <20100225091500.GB2903@gmail.com>
On Thu, Feb 25, 2010 at 10:15 AM, David Aguilar <davvid@gmail.com> wrote:
Show 37 quoted lines
> On Wed, Feb 24, 2010 at 04:13:01PM +0800, Frank Li wrote:
>>
>> > Many users already have SSH_ASKPASS defined. It would be very
>> > nice if we supported SSH_ASKPASS as a fallback when GIT_ASKPASS
>> > is not provided.
>> >
>>
>> I consider add such fallback at git.c. when user use git svn, git
>> main program will be called firstly.
>> git main entry will check if GIT_ASKPASS and SSH_ASKPASS, if
>> SSH_ASKPASS set but GIT_ASKPASS not set,
>> GIT_ASKPASS will be set as SSH_ASKPASS.
>>
>> Do you think we needs add such check at git-svn.perl ?
>>
>> best regards
>> Frank Li
>
> Interesting question. I had never thought of moving the
> fallback to git.
>
> I would have done it in the script as a localized fix but
> I definately see the value in aiding scripts from
> all having to implement this same fallback, though:
>
> $ENV{GIT_ASKPASS} ||= $ENV{SSH_ASKPASS};
>
> If Junio, Eric, and the git list think that this should
> live in git instead then by all means.
>
> --
> David
> --
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>I don't think localized fix in every scripts, third party application is the good and the trivial solution for this issue. I'm just a simple TortoiseGIT user, but I guess other GUIs, frontends suffer from this problem too.
Best Regards, Laszlo Papp