Re: [PATCH 1/1] Use GIT_ASKPASS environment to launch thirdpart UI app to get password

From: Frank Li <lznuaa@gmail.com>
Date: Feb 24, 2010, 08:13 UTC
Message-ID: <1976ea661002240013j164fc875o469c0dcdf74afe0c@mail.gmail.com>
In-Reply-To: <20100224051307.GA3232@gmail.com>

Show 11 quoted lines

> -- >8 --
> Subject: [PATCH] git-svn: Support retrieving passwords with GIT_ASKPASS
>
> git-svn reads passwords from an interactive terminal.
> This behavior causes GUIs to hang waiting for git-svn to
> complete.
>
> Fix this problem by allowing a password-retrieving command
> to be specified in GIT_ASKPASS.  SSH_ASKPASS is supported
> as a fallback when GIT_ASKPASS is not provided.
>

Okay, I will change it.

Show 7 quoted lines

>
> I think Junio mentioned this in passing but I'll repeat it.
>
> Many users already have SSH_ASKPASS defined.  It would be very
> nice if we supported SSH_ASKPASS as a fallback when GIT_ASKPASS
> is not provided.
>

I consider add such fallback at git.c. when user use git svn, git main program will be called firstly. git main entry will check if GIT_ASKPASS and SSH_ASKPASS, if SSH_ASKPASS set but GIT_ASKPASS not set, GIT_ASKPASS will be set as SSH_ASKPASS.

Do you think we needs add such check at git-svn.perl ?

best regards Frank Li