Re: [PATCH 1/3] send-mail: improve checks for valid_fqdn

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: May 4, 2025, 14:22 UTC
Message-ID: <a2ceea8b-8354-4316-88ec-54111fb98d69@app.fastmail.com>
In-Reply-To: <PN3PR01MB95975D45B072101812714C72B88F2@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>

On Sun, May 4, 2025, at 15:54, Aditya Garg wrote:

> [1]: https://datatracker.ietf.org/doc/html/rfc1035
> Signed-off-by: Aditya Garg <gargaditya08@live.com>

Finding the s-o-b here works fine since only 25% of the trailer block must be valid trailers, but it’s probably best in general to separate footnotes and the trailer block with a blank line.

Show 22 quoted lines

> ---
>  git-send-email.perl | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 4215f8f7e9..4c143e24bf 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1359,7 +1359,8 @@ sub process_address_list {
>
>  sub valid_fqdn {
>  	my $domain = shift;
> -	return defined $domain && !($^O eq 'darwin' && $domain =~ /\.local$/)
> && $domain =~ /\./;
> +	return defined $domain && !($^O eq 'darwin' && $domain =~ /\.local$/)
> +		&& $domain  =~
> /^(?!-)[A-Za-z0-9-]{1,63}(?<!-)(\.[A-Za-z0-9-]{1,63})+$/;
>  }
>
>  sub maildomain_net {
> --
> 2.49.0