Re: [PATCH 1/3] send-mail: improve checks for valid_fqdn

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: May 4, 2025, 16:05 UTC
Message-ID: <96413038-8b21-44f7-b426-ea9d61b90cc0@app.fastmail.com>
In-Reply-To: <PN3PR01MB95976EC68E23CDB5A77AE741B88F2@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>

On Sun, May 4, 2025, at 17:26, Aditya Garg wrote:

Show 11 quoted lines

>> On 4 May 2025, at 7:53 PM, Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com> wrote:
>>
>> On Sun, May 4, 2025, at 15:54, Aditya Garg wrote:
>>> [1]: https://datatracker.ietf.org/doc/html/rfc1035
>>> Signed-off-by: Aditya Garg <gargaditya08@live.com>
>>
>> Finding the s-o-b here works fine since only 25% of the trailer block
>> must be valid trailers, but it’s probably best in general to separate
>> footnotes and the trailer block with a blank line.
>
> Sure. I'll wait for some more reviews and send a v2 tomorrow.

If there are no other comments then that’s just a nitpick. :) Maybe a v2 won’t be needed.