git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir()

From
DKDmitry Kakurin <dmitry.kakurin@gmail.com>
Date
Jan 3, 2008, 06:26 UTC
Message-ID
<a1bbc6950801022226k32cfd9b9t62939b3cbedef247@mail.gmail.com>
In-Reply-To
<42F546CE-2564-4DFB-B260-FD50BD51F2BB@zib.de>
On Jan 2, 2008 10:02 PM, Steffen Prohaska <prohaska@zib.de> wrote:
Show 25 quoted lines
>
>
> On Jan 3, 2008, at 5:07 AM, Dmitry Kakurin wrote:
>
> > On Jan 1, 2008 10:52 AM, Steffen Prohaska <prohaska@zib.de> wrote:
> >> In conclusion, using setenv() as in the original code instead of
> >> set_git_dir() should be safe and this patch is not needed.
> >>
> >> I tend to revert the changes in msysgit and see if we hit any
> >> problems.  But I'll wait until 1.5.4 is released.
> >>
> >>        Steffen
> >
> > Please don't revert this change. I've made it in response to git clone
> > failing, commit 855f254b2b5b083a63fc8d7709a42e2cbdc5a136.
>
> I know.  But I cannot reproduce the error.
>
> Do you have a test case that demonstrates the problem?
>
> I either want to see the patch upstream in official git or revert
> it in msysgit.  But I cannot answer the questions that were
> raised after I sent the patch (see earlier in this thread).  And
> I can't see the problem that your patch solves, even after
> spending some time on reading and instrumenting code.

I remember that the problem was as simple as git clone or git clone --bare failing. Also I'm not sure if it matters but I'm running Vista. There is also a chance that code has changed since then and this problem went away.

-- 
- Dmitry
Previous: Steffen ProhaskaNext: Steffen Prohaska
Message 16 of 18 in “msysgit fallout”
  1. 0/3 msysgit falloutSteffen Prohaska, Nov 21, 2007
  2. 1/3 sha1_file.c: Fix size_t related printf format warningsSteffen Prohaska, Nov 21, 2007
  3. 2/3 builtin-init-db: use get_git_dir() instead of getenv()Steffen Prohaska, Nov 21, 2007
  4. 3/3 Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir()Steffen Prohaska, Nov 21, 2007
  5. Johannes SchindelinNov 22, 2007
  6. Junio C HamanoNov 22, 2007
  7. Steffen ProhaskaNov 22, 2007
  8. Junio C HamanoNov 22, 2007
  9. Steffen ProhaskaNov 22, 2007
  10. Johannes SixtNov 22, 2007
  11. Steffen ProhaskaNov 22, 2007
  12. Johannes SchindelinNov 22, 2007
  13. Steffen ProhaskaJan 1, 2008
  14. Dmitry KakurinJan 3, 2008
  15. Steffen ProhaskaJan 3, 2008
  16. Dmitry KakurinJan 3, 2008
  17. Steffen ProhaskaJan 3, 2008
  18. Johannes SixtNov 22, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.