Re: [PATCH 3/3] Replace setenv(GIT_DIR_ENVIRONMENT, ...) with set_git_dir()

From: Steffen Prohaska <prohaska@zib.de>
Date: Jan 3, 2008, 07:53 UTC
Message-ID: <8BA05F64-A3E6-48B8-9A8C-1BA361DDF65E@zib.de>
In-Reply-To: <a1bbc6950801022226k32cfd9b9t62939b3cbedef247@mail.gmail.com>

On Jan 3, 2008, at 7:26 AM, Dmitry Kakurin wrote:

Show 30 quoted lines

> On Jan 2, 2008 10:02 PM, Steffen Prohaska <prohaska@zib.de> wrote:
>>
>>
>> On Jan 3, 2008, at 5:07 AM, Dmitry Kakurin wrote:
>>
>>> On Jan 1, 2008 10:52 AM, Steffen Prohaska <prohaska@zib.de> wrote:
>>>> In conclusion, using setenv() as in the original code instead of
>>>> set_git_dir() should be safe and this patch is not needed.
>>>>
>>>> I tend to revert the changes in msysgit and see if we hit any
>>>> problems.  But I'll wait until 1.5.4 is released.
>>>>
>>>>        Steffen
>>>
>>> Please don't revert this change. I've made it in response to git  
>>> clone
>>> failing, commit 855f254b2b5b083a63fc8d7709a42e2cbdc5a136.
>>
>> I know.  But I cannot reproduce the error.
>>
>> Do you have a test case that demonstrates the problem?
>>
>> I either want to see the patch upstream in official git or revert
>> it in msysgit.  But I cannot answer the questions that were
>> raised after I sent the patch (see earlier in this thread).  And
>> I can't see the problem that your patch solves, even after
>> spending some time on reading and instrumenting code.
>
> I remember that the problem was as simple as git clone or git clone
> --bare failing.

This is what I understood from the commit message.

I need a script that I can run to see the error. All tests that come with git pass (on my machine).

> Also I'm not sure if it matters but I'm running Vista.

It only matters if you see an error on Vista that I don't see on XP. If this was the case I'd debug on Vista.

> There is also a chance that code has changed since then and this
> problem went away.

Maybe.

	Steffen