[PATCH v10 6/8] list-objects-filter: use BUG rather than die
- From
Matthew DeVore <matvore@google.com>
- Date
- Oct 3, 2018, 19:52 UTC
- Message-ID
- <a16413f2388ef2d08448e4326c0f010a0b81501b.1538592829.git.matvore@google.com>
- In-Reply-To
- <cover.1538592829.git.matvore@google.com>
In some cases in this file, BUG makes more sense than die. In such cases, a we get there from a coding error rather than a user error.
'return' has been removed following some instances of BUG since BUG does not return.
Signed-off-by: Matthew DeVore <matvore@google.com> --- list-objects-filter.c | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/list-objects-filter.c b/list-objects-filter.c index a0ba78b20..5f8b1a002 100644 --- a/list-objects-filter.c +++ b/list-objects-filter.c @@ -44,8 +44,7 @@ static enum list_objects_filter_result filter_blobs_none( switch (filter_situation) { default: - die("unknown filter_situation"); - return LOFR_ZERO; + BUG("unknown filter_situation: %d", filter_situation); case LOFS_BEGIN_TREE: assert(obj->type == OBJ_TREE); @@ -102,8 +101,7 @@ static enum list_objects_filter_result filter_blobs_limit( switch (filter_situation) { default: - die("unknown filter_situation"); - return LOFR_ZERO; + BUG("unknown filter_situation: %d", filter_situation); case LOFS_BEGIN_TREE: assert(obj->type == OBJ_TREE); @@ -208,8 +206,7 @@ static enum list_objects_filter_result filter_sparse( switch (filter_situation) { default: - die("unknown filter_situation"); - return LOFR_ZERO; + BUG("unknown filter_situation: %d", filter_situation); case LOFS_BEGIN_TREE: assert(obj->type == OBJ_TREE); @@ -389,7 +386,7 @@ void *list_objects_filter__init( assert((sizeof(s_filters) / sizeof(s_filters[0])) == LOFC__COUNT); if (filter_options->choice >= LOFC__COUNT) - die("invalid list-objects filter choice: %d", + BUG("invalid list-objects filter choice: %d", filter_options->choice); init_fn = s_filters[filter_options->choice];
-- 2.19.0.605.g01d371f741-goog