Re: [PATCH v6 6/6] list-objects-filter: implement filter tree:0

From: Stefan Beller <sbeller@google.com>
Date: Aug 21, 2018, 00:29 UTC
Message-ID: <CAGZ79kZfZ2FWfgrvb82YxXP7zHjYDp0J_581ZHgG3un1phHxGg@mail.gmail.com>
In-Reply-To: <CAMfpvhKPJijO_E2FRh-UtrOthEc2YTaG0=1ToYy3akjzWUZWiw@mail.gmail.com>

Show 11 quoted lines

> > heh. Thanks for switching the style; I should have emphasized that
> > (after reflection) I found them equally good, I am used to one
> > over the other more.
> It seems marginally better to me. I also noticed a clean-up patch
> going by that aggressively switched to test_must_be_empty wherever
> possible: https://public-inbox.org/git/20180819215725.29001-1-szeder.dev@gmail.com/
>
> OTOH, if it were up to me I would have just gotten rid of
> test_must_be_empty and used an existing function with the right
> argument, like `test_cmp /dev/null` - but using some form consistently
> is the most important, whatever it is.

/dev/null, eh? It shows you don't use Windows on a day to day basis. ;-) But yeah consistency is really good to have. :)