Re: [PATCH v5 2/2] tests(mingw): avoid very slow `mingw_test_cmp`
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Dec 6, 2022, 21:52 UTC
- Message-ID
- <a11c51bc-f419-f128-05c9-d9706aabc665@kdbg.org>
- In-Reply-To
- <6a80fab7e3936ec56e1583d6136d47487327e907.1670339267.git.gitgitgadget@gmail.com>
Am 06.12.22 um 16:07 schrieb Johannes Schindelin via GitGitGadget:
Show 10 quoted lines
> diff --git a/t/test-lib.sh b/t/test-lib.sh > index 7726d1da88a..f8c6205e08f 100644 > --- a/t/test-lib.sh > +++ b/t/test-lib.sh > @@ -1546,7 +1546,7 @@ case $uname_s in > test_set_prereq SED_STRIPS_CR > test_set_prereq GREP_STRIPS_CR > test_set_prereq WINDOWS > - GIT_TEST_CMP=mingw_test_cmp > + GIT_TEST_CMP="GIT_DIR=/dev/null git diff --no-index --ignore-cr-at-eol --"
After René's work, it should be possible to drop this setting on Windows altogether.
I started doing that, and when I proof-read the patch, I noticed the SED_STRIPS_CR and GREP_STRIPS_CR prerequisites that are visible in the context lines of this hunk. I wanted to explore whether they can be removed as well, but I ran out of time.
-- Hannes