Re: [PATCH v3 2/2] tests(mingw): avoid very slow `mingw_test_cmp`
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Nov 19, 2022, 02:53 UTC
- Message-ID
- <Y3hFITt+8VUubC8v@nand.local>
- In-Reply-To
- <xmqqv8nbkg77.fsf@gitster.g>
On Fri, Nov 18, 2022 at 03:15:08PM -0800, Junio C Hamano wrote:
Show 13 quoted lines
> Taylor Blau <me@ttaylorr.com> writes: > > > One thing that the commit message doesn't allude to (that is covered in > > the earlier discussion) is why it is important to pass > > `--ignore-cr-at-eol`. I think that is worth mentioning here. > > Isn't it because Git on the platform is expected to use CRLF in > certain places, unlike on other platforms where LF is used, but the > platform port hasn't adjusted tests to match that expectation? And > vice versa, where Git is expected to produce LF terminated text > everywhere but the expected output is not "ported" to force LF > termination and instead produces CRLF terminated text on platforms > whose native line ending is CRLF?
Yes, I think that's right. My suggestion to Johannes was to (a) make sure that your and my understanding is correct, and (b) to memorialize that understanding in the commit message itself.
Show 7 quoted lines
> Use of "ignore-cr-at-eol" may allow such tests that are not ported > correctly to prepare expected output with a "wrong" line ending and > still pass, and I do think it may be an expedite way to make tests > appear to pass. > > But I worry that it may not be a good thing for the health of the > Windows port in the longer term.
I share your concerns, too.
Thanks, Taylor