git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/3] t/t7811-grep-open.sh: ensure fake "less" is made executable

From
Brandon Casey <casey@nrlssc.navy.mil>
Date
Jun 21, 2010, 17:37 UTC
Message-ID
<__CrpvAIIX9lgHHkBLHB9a3UByh6vEB5nG8C7-bzzaY-zhXjKlkZfsB4GNmQRsIYGu10jf-0sjU@cipher.nrlssc.navy.mil>
In-Reply-To
<__CrpvAIIX9lgHHkBLHB9fuuN7Rspzl7LFSDSwXwVCT6rYs_YOUHNMf7JZQbKaPHRl6AjsJ9dx8@cipher.nrlssc.navy.mil>
From: Brandon Casey <drafnel@gmail.com>

The fake "less" script was not being made executable. This can cause the tests that follow to fail. This failure is not apparent on platforms which have DEFAULT_PAGER set to the string "less", since lib-pager.sh will have set the $less variable to "less" and the SIMPLEPAGER prerequisite will have been set, and so the "less" script will have already been created properly and made executable in test 2 'git grep -O'. On platforms which set DEFAULT_PAGER to something like "more", no such script will have been previously created, and tests 7 and 8 will fail.

So, add a call to chmod to make the fake "less" script executable.
Signed-off-by: Brandon Casey <casey@nrlssc.navy.mil>
---
 t/t7811-grep-open.sh |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/t/t7811-grep-open.sh b/t/t7811-grep-open.sh
index 8db4fc8..2e5c701 100755
--- a/t/t7811-grep-open.sh
+++ b/t/t7811-grep-open.sh
@@ -84,10 +84,11 @@ test_expect_success 'git grep -O --no-index' '
 '
 
 test_expect_success 'setup: fake "less"' '
-	cat >less <<-\EOF
+	cat >less <<-\EOF &&
 	#!/bin/sh
 	printf "%s\n" "$@" >actual
 	EOF
+	chmod +x less
 '
 
 test_expect_success 'git grep -O jumps to line in less' '
-- 
1.6.6.2
Previous: Brandon CaseyNext: Brandon Casey
Message 2 of 4 in “t/lib-pager.sh: remove unnecessary '^' from 'expr' regular expression”
  1. 1/3 t/lib-pager.sh: remove unnecessary '^' from 'expr' regular expressionBrandon Casey, Jun 21, 2010
  2. 2/3 t/t7811-grep-open.sh: ensure fake "less" is made executableBrandon Casey, Jun 21, 2010
  3. 3/3 t/t7811-grep-open.sh: remove broken/redundant creation of fake "less" scriptBrandon Casey, Jun 21, 2010
  4. Junio C HamanoJun 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.