git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/3] t/lib-pager.sh: remove unnecessary '^' from 'expr' regular expression

From
Junio C Hamano <junio@pobox.com>
Date
Jun 21, 2010, 18:11 UTC
Message-ID
<7vd3vki7d7.fsf@alter.siamese.dyndns.org>
In-Reply-To
<__CrpvAIIX9lgHHkBLHB9fuuN7Rspzl7LFSDSwXwVCT6rYs_YOUHNMf7JZQbKaPHRl6AjsJ9dx8@cipher.nrlssc.navy.mil>
Brandon Casey <casey@nrlssc.navy.mil> writes:
> From: Brandon Casey <drafnel@gmail.com>
>
> Regular expressions matched by 'expr' have an implicit '^' at the beginning
> of them and so are anchored to the beginning of the string.
Oh, of course; I should have caught this earlier.

$ git grep -n -e 'expr .*: .*['\''"]^' t/lib-pager.sh:12:if expr "$less" : '^[a-z][a-z]*$' >/dev/null t/t7005-editor.sh:16:if ! expr "$vi" : '^[a-z]*$' >/dev/null t/t7006-pager.sh:113: ! expr "$firstline" : "^[a-zA-Z]" >/dev/null

I'll fix the other two; thanks.
Previous: Brandon Casey
Message 4 of 4 in “t/lib-pager.sh: remove unnecessary '^' from 'expr' regular expression”
  1. 1/3 t/lib-pager.sh: remove unnecessary '^' from 'expr' regular expressionBrandon Casey, Jun 21, 2010
  2. 2/3 t/t7811-grep-open.sh: ensure fake "less" is made executableBrandon Casey, Jun 21, 2010
  3. 3/3 t/t7811-grep-open.sh: remove broken/redundant creation of fake "less" scriptBrandon Casey, Jun 21, 2010
  4. Junio C HamanoJun 21, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.