git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/2] C23 compatibility

From
brian m. carlson <sandals@crustytoothpaste.net>
Date
Nov 18, 2024, 22:11 UTC
Message-ID
<Zzu7oiJ8PTWgmJUc@tapette.crustytoothpaste.net>
In-Reply-To
<Zzrwf2B36RgbhxEa@pks.im>
On 2024-11-18 at 07:45:03, Patrick Steinhardt wrote:
> Both of the patches look obviously good to me. I was a bit surprised
> that this is required in the first place as I thought we were passing
> `-std=gnu99` to our compilers, but that is not the case with our current
> Makefile. So I must have been misremembering.

We can't do that because FreeBSD's system headers require C11 and won't work with `-std=gnu99`, in addition to the general unportability of that construct as mentioned by Peff. There's a comment to that effect in `config.mak.dev`.

I'm pleased you found the patches acceptable, though.
-- 
brian m. carlson (they/them or he/him)
Toronto, Ontario, CA
Previous: Jeff King
Message 8 of 8 in “Build failure with -std=gnu23 (GCC 15 default)”
  1. Sam JamesNov 16, 2024
  2. 0/2 C23 compatibilitybrian m. carlson, Nov 17, 2024
  3. 2/2 reflog: rename unreachablebrian m. carlson, Nov 17, 2024
  4. 1/2 index-pack: rename struct thread_localbrian m. carlson, Nov 17, 2024
  5. Sam JamesNov 17, 2024
  6. Patrick SteinhardtNov 18, 2024
  7. Jeff KingNov 18, 2024
  8. brian m. carlsonNov 18, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.