Re: [PATCH 0/2] C23 compatibility

From: Patrick Steinhardt <ps@pks.im>
Date: Nov 18, 2024, 07:45 UTC
Message-ID: <Zzrwf2B36RgbhxEa@pks.im>
In-Reply-To: <20241117013149.576671-1-sandals@crustytoothpaste.net>

On Sun, Nov 17, 2024 at 01:31:47AM +0000, brian m. carlson wrote:

Show 12 quoted lines

> Most of our code works fine in C23, but there are some new additions to
> the standard that conflict with either our struct tags or functions.
> With this series, the code compiles and passes the testsuite with
> -std=c23 on GCC 14.2.0.
> 
> brian m. carlson (2):
>   index-pack: rename struct thread_local
>   reflog: rename unreachable
> 
>  builtin/index-pack.c | 10 +++++-----
>  reflog.c             |  4 ++--
>  2 files changed, 7 insertions(+), 7 deletions(-)

Both of the patches look obviously good to me. I was a bit surprised that this is required in the first place as I thought we were passing `-std=gnu99` to our compilers, but that is not the case with our current Makefile. So I must have been misremembering.

Thanks!

Patrick