git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t: fix typos

From
Andrew Kreimer <algonell@gmail.com>
Date
Oct 18, 2024, 16:51 UTC
Message-ID
<ZxKSFBl_pV2r99dY@void.void>
In-Reply-To
<ZxFyKXDCJkRZYYQY@nand.local>
On Thu, Oct 17, 2024 at 04:23:05PM -0400, Taylor Blau wrote:
> Please do not base new topics on 'seen', as it is likely to change
> day-to-day.
> 
Noted, thank you.
Show 11 quoted lines
> > @@ -117,7 +117,7 @@ do
> >  		git config extensions.objectformat $hash &&
> >  		git config extensions.compatobjectformat $(compat_hash $hash) &&
> >  		git config gpg.program $TEST_DIRECTORY/t1016/gpg &&
> > -		echo "Hellow World!" > hello &&
> > +		echo "Hello World!" > hello &&
> 
> Not the fault of this patch, but there is a style issue here that there
> should not be a space between '>' and 'hello' (i.e. it should read
> '>hello', not '> hello').
> 
Do you mean that '> more' and '> another' should be handled similarly?
> Likewise with the 'git config' use above should be test_config, etc. But
> this patch does not need to care about that, since it did not introduce
> those issues in the first place.
> 
Will try to address this one.
Previous: Taylor BlauNext: Kristoffer Haugsbakk
Message 3 of 9 in “t: fix typos”
  1. t: fix typosAndrew Kreimer, Oct 17, 2024
  2. Taylor BlauOct 17, 2024
  3. Andrew KreimerOct 18, 2024
  4. Kristoffer HaugsbakkOct 18, 2024
  5. Andrew KreimerOct 18, 2024
  6. Taylor BlauOct 18, 2024
  7. Taylor BlauOct 18, 2024
  8. Taylor BlauOct 18, 2024
  9. Andrew KreimerOct 19, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.