Re: [PATCH] t: fix typos

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 17, 2024, 20:23 UTC
Message-ID: <ZxFyKXDCJkRZYYQY@nand.local>
In-Reply-To: <20241017112835.10100-1-algonell@gmail.com>

On Thu, Oct 17, 2024 at 02:28:35PM +0300, Andrew Kreimer wrote:

Show 8 quoted lines

> Fix typos in documentation, comments, etc.
>
> Via codespell.
>
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> ---
> Synced with:
>   - Merge branch 'la/trailer-info' into seen.

Please do not base new topics on 'seen', as it is likely to change day-to-day.

Show 6 quoted lines

> @@ -117,7 +117,7 @@ do
>  		git config extensions.objectformat $hash &&
>  		git config extensions.compatobjectformat $(compat_hash $hash) &&
>  		git config gpg.program $TEST_DIRECTORY/t1016/gpg &&
> -		echo "Hellow World!" > hello &&
> +		echo "Hello World!" > hello &&

Not the fault of this patch, but there is a style issue here that there should not be a space between '>' and 'hello' (i.e. it should read '>hello', not '> hello').

Likewise with the 'git config' use above should be test_config, etc. But this patch does not need to care about that, since it did not introduce those issues in the first place.

The rest looks good, thanks.

Thanks, Taylor