Re: [PATCH] builtin/credential-cache--daemon: fix error when "exit"ing on Cygwin

From: Patrick Steinhardt <ps@pks.im>
Date: Oct 17, 2024, 08:46 UTC
Message-ID: <ZxDOydD7kpSGchiQ@pks.im>
In-Reply-To: <20241017023319.GA1858436@coredump.intra.peff.net>

On Wed, Oct 16, 2024 at 10:33:19PM -0400, Jeff King wrote:

Show 18 quoted lines

> On Wed, Oct 16, 2024 at 04:28:49PM -0400, Taylor Blau wrote:
> 
> > > This all seemed eerily familiar. Try this thread:
> > >
> > >   https://lore.kernel.org/git/9dc3e85f-a532-6cff-de11-1dfb2e4bc6b6@ramsayjones.plus.com/
> > >
> > > It looks like the conclusion was that we should adjust errno handling on
> > > the client side, but nobody ever followed up with an actual patch.
> > 
> > Thanks for digging. It would be great if you both and Ramsay could unify
> > on an agreeable path forward here.
> 
> I think the patch Ramsay posted elsewhere is the right way forward.
> Hopefully he can fill out a commit message with the summary and then we
> can proceed.
> 
> (I'm happy to help with explaining the credential-cache side, but I
> would just be hand-waving on the cygwin parts).

Sounds great to me -- in that case, let's just drop my patch. I was basically just trying to get somebody to have a look at the issue, and it very much seems like I succeeded :)

Ramsay, do you want to polish your patch with a commit message or shall I pick it up and iterate on it?

Thanks all for chiming in!

Patrick