Re: [PATCH] credential-cache: treat ECONNABORTED like ECONNRESET

From: Jeff King <peff@peff.net>
Date: Oct 19, 2024, 21:21 UTC
Message-ID: <20241019212135.GB589728@coredump.intra.peff.net>
In-Reply-To: <71e8e44e-dbf9-482e-a351-3a82aa1ca5dd@app.fastmail.com>

On Fri, Oct 18, 2024 at 11:27:50PM +0200, Kristoffer Haugsbakk wrote:

Show 10 quoted lines

> On Fri, Oct 18, 2024, at 07:29, Jeff King wrote:
> > [jk: commit message]
> >
> > Signed-off-by: Jeff King <peff@peff.net>
> 
> Just curious.  Why this bracket comment (non-trailer line or whatever it
> is called) and not a regular trailer?  All the bracket comments that
> I’ve seen give some comment, often about tweaking the patch or the
> commit message.  In this case though the whole commit message is written
> by one person.

I assigned authorship to Ramsay, so my name is not otherwise mentioned, but appears in the signoff. So it was a way of mentioning what I contributed (both for credit, but also in case anybody has questions later).

I guess "Commit-message-by:" would work, too. ;) I guess you could likewise argue that I'm a co-author.

I think in the usual trailer order, it would be:

  Signed-off-by: Ramsay
  [jk: add commit message]
  Signed-off-by: me

but I didn't want to forge his S-o-b without asking first.

-Peff