Re: [PATCH v3 0/2] builtin/shortlog: explicitly set hash algo when there is no repo

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 16, 2024, 19:32 UTC
Message-ID: <ZxAUwxswtz4HmFeg@nand.local>
In-Reply-To: <20241016182124.48148-1-wolf@oriole.systems>

On Wed, Oct 16, 2024 at 08:21:22PM +0200, Wolfgang Müller wrote:

Show 11 quoted lines

> Here's v3 of this series. CI should now pass as the code has been moved
> below any declarations. The regression test has been simplified, thanks
> to Eric's input.
>
> I added another commit with a test for git-shortlog(1) that makes sure
> it can process logs obtained from a repo with --object-format=sha256.
> Thanks to Patrick for the suggestion and pointers.
>
> Wolfgang Müller (2):
>   builtin/shortlog: explicitly set hash algo when there is no repo
>   shortlog: Test reading a log from a SHA256 repo in a non-git directory

Thanks. I took a look at this new round and it is looking close to me.

I had a couple of small-ish comments that I think would be good to address in a new round. But if you feel strongly that the current round is good as-is, I'm happy to hear arguments in that direction, too ;-).

Thanks, Taylor