Re: [RFC PATCH] builtin/shortlog: explicitly set hash algo when there is no repo

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Oct 15, 2024, 09:47 UTC
Message-ID: <08bdd8dd-06d8-47a6-8b44-fa6add14d60a@app.fastmail.com>
In-Reply-To: <r4btv3hmwv6haflwhmjbjshova4wnth5mkbknsuuqcvose5lix@bvy5e6gxnit6>

On Tue, Oct 15, 2024, at 11:33, Wolfgang Müller wrote:

> > […]
>
> Was this topic maybe missed? It's not a critical fix but would solve a
> segfault that is pretty easy for a user to trigger.

I can confirm that this gives me a segfault:

``` # Directory which is not tracked cd ~ git shortlog --author=Kristoffer ```

Maybe a few things could make the change more ready to be included:

1. A regression test for that segfault
2. A quickfix (which you indicate below the three-dash/hyphens) can be
   documented in the comment above the code with a `NEEDSWORK`

-- 
Kristoffer Haugsbakk

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.