Re: [PATCH v2 1/1] git-config.1: remove value from positional args in unset usage
On Tue, Oct 08, 2024 at 11:20:48AM -0700, Junio C Hamano wrote:
Show 19 quoted lines
> Josh Heinrichs <joshiheinrichs@gmail.com> writes:
>
> > The synopsis for `git config unset` mentions two positional arguments:
> > `<name>` and `<value>`. While the first argument is correct, the second
> > is not. Users are expected to provide the value via `--value=<value>`.
> >
> > Remove the positional argument. The `--value=<value>` option is already
> > documented correctly, so this is all we need to do to fix the
> > documentation.
> >
> > Signed-off-by: Josh Heinrichs <joshiheinrichs@gmail.com>
> > ---
> > Documentation/git-config.txt | 2 +-
> > builtin/config.c | 4 ++--
> > 2 files changed, 3 insertions(+), 3 deletions(-)
>
> Patrick, do you mind to forge your Reviewed-by for this one?
>
> Will queue. Thanks, both.
No, please feel free to add it.
Reviewed-by: Patrick Steinhardt <ps@pks.im>
Patrick