git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/1] git-config.1: remove value from positional args in unset usage

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 9, 2024, 03:37 UTC
Message-ID
<ZwX6byY2IVFvKezP@pks.im>
In-Reply-To
<xmqqfrp61mnz.fsf@gitster.g>
On Tue, Oct 08, 2024 at 11:20:48AM -0700, Junio C Hamano wrote:
Show 19 quoted lines
> Josh Heinrichs <joshiheinrichs@gmail.com> writes:
> 
> > The synopsis for `git config unset` mentions two positional arguments:
> > `<name>` and `<value>`. While the first argument is correct, the second
> > is not. Users are expected to provide the value via `--value=<value>`.
> >
> > Remove the positional argument. The `--value=<value>` option is already
> > documented correctly, so this is all we need to do to fix the
> > documentation.
> >
> > Signed-off-by: Josh Heinrichs <joshiheinrichs@gmail.com>
> > ---
> >  Documentation/git-config.txt | 2 +-
> >  builtin/config.c             | 4 ++--
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> Patrick, do you mind to forge your Reviewed-by for this one?
> 
> Will queue.  Thanks, both.
No, please feel free to add it.
    Reviewed-by: Patrick Steinhardt <ps@pks.im>
Patrick
Previous: Junio C Hamano
Message 7 of 7 in “Remove value from positional args in config unset usage”
  1. 0/1 Remove value from positional args in config unset usageJosh Heinrichs, Oct 8, 2024
  2. 1/1 git-config.1: remove value from positional args in unset usageJosh Heinrichs, Oct 8, 2024
  3. Patrick SteinhardtOct 8, 2024
  4. 0/1 Remove value from position args in config unset usageJosh Heinrichs, Oct 8, 2024
  5. 1/1 git-config.1: remove value from positional args in unset usageJosh Heinrichs, Oct 8, 2024
  6. Junio C HamanoOct 8, 2024
  7. Patrick SteinhardtOct 9, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.