[PATCH v2 0/1] Remove value from position args in config unset usage
- From
Josh Heinrichs <joshiheinrichs@gmail.com>
- Date
- Oct 8, 2024, 14:29 UTC
- Message-ID
- <20241008142920.570244-1-joshiheinrichs@gmail.com>
- In-Reply-To
- <20241008040749.69801-1-joshiheinrichs@gmail.com>
Hello!
This version addresses the issues with my commit message that Patrick flagged in v1.
Josh
Josh Heinrichs (1): git-config.1: remove value from positional args in unset usage
Documentation/git-config.txt | 2 +- builtin/config.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
Range-diff against v1:
1: 4bb9c65fb9 ! 1: e3b5f3c8b2 git-config.1: remove value from positional args in unset usage
@@ Metadata
## Commit message ##
git-config.1: remove value from positional args in unset usage
- A single positional argument appears to be enforcecd at
- builtin/config.c:993. Values need to be provided via --value.
+ The synopsis for `git config unset` mentions two positional arguments:
+ `<name>` and `<value>`. While the first argument is correct, the second
+ is not. Users are expected to provide the value via `--value=<value>`.
+
+ Remove the positional argument. The `--value=<value>` option is already
+ documented correctly, so this is all we need to do to fix the
+ documentation.
+
+ Signed-off-by: Josh Heinrichs <joshiheinrichs@gmail.com>
## Documentation/git-config.txt ##
@@ Documentation/git-config.txt: SYNOPSIS-- 2.25.1