git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 0/1] Remove value from position args in config unset usage

From
Josh Heinrichs <joshiheinrichs@gmail.com>
Date
Oct 8, 2024, 14:29 UTC
Message-ID
<20241008142920.570244-1-joshiheinrichs@gmail.com>
In-Reply-To
<20241008040749.69801-1-joshiheinrichs@gmail.com>
Hello!

This version addresses the issues with my commit message that Patrick flagged in v1.

Josh
Josh Heinrichs (1):
  git-config.1: remove value from positional args in unset usage
 Documentation/git-config.txt | 2 +-
 builtin/config.c             | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)
Range-diff against v1:
1:  4bb9c65fb9 ! 1:  e3b5f3c8b2 git-config.1: remove value from positional args in unset usage
    @@ Metadata
      ## Commit message ##
         git-config.1: remove value from positional args in unset usage
     
    -    A single positional argument appears to be enforcecd at
    -    builtin/config.c:993. Values need to be provided via --value.
    +    The synopsis for `git config unset` mentions two positional arguments:
    +    `<name>` and `<value>`. While the first argument is correct, the second
    +    is not. Users are expected to provide the value via `--value=<value>`.
    +
    +    Remove the positional argument. The `--value=<value>` option is already
    +    documented correctly, so this is all we need to do to fix the
    +    documentation.
    +
    +    Signed-off-by: Josh Heinrichs <joshiheinrichs@gmail.com>
     
      ## Documentation/git-config.txt ##
     @@ Documentation/git-config.txt: SYNOPSIS
-- 
2.25.1
Previous: Patrick SteinhardtNext: Josh Heinrichs
Message 4 of 7 in “Remove value from positional args in config unset usage”
  1. 0/1 Remove value from positional args in config unset usageJosh Heinrichs, Oct 8, 2024
  2. 1/1 git-config.1: remove value from positional args in unset usageJosh Heinrichs, Oct 8, 2024
  3. Patrick SteinhardtOct 8, 2024
  4. 0/1 Remove value from position args in config unset usageJosh Heinrichs, Oct 8, 2024
  5. 1/1 git-config.1: remove value from positional args in unset usageJosh Heinrichs, Oct 8, 2024
  6. Junio C HamanoOct 8, 2024
  7. Patrick SteinhardtOct 9, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.