Re: [PATCH v2 00/10] reftable: stop using `struct strbuf`

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 14, 2024, 22:44 UTC
Message-ID: <Zw2e0w5bkDO4l/Qs@nand.local>
In-Reply-To: <cover.1728910726.git.ps@pks.im>

On Mon, Oct 14, 2024 at 03:02:16PM +0200, Patrick Steinhardt wrote:

Show 6 quoted lines

> Hi,
>
> this is the second part of my patch series that stop using `struct
> strbuf` in the reftable library. This is done such that the reftable
> library becomes standalone again and so that we can use the pluggable
> allocators part of the library.

I reviewed this round, and it looks generally good to me. I feel somewhat unhappy to have to force the reftable backend to implement its own strbuf-like functionality.

So I think it may be worth considering whether or not we can reuse Git's strbuf implementation through a vtable or similar. But it may not be immediately possible since that implementation just die()s on error, can't easily swap out the allocator, etc. So perhaps this is the best path forward, it just feels somewhat unsatisfying to me.

Thanks, Taylor