Re: [PATCH v2 04/10] reftable: convert from `strbuf` to `reftable_buf`
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Oct 14, 2024, 22:35 UTC
- Message-ID
- <Zw2cv2G6ITf0aTkZ@nand.local>
- In-Reply-To
- <e1ff1af1f302490f8d79301a73f7cd48314477ba.1728910727.git.ps@pks.im>
On Mon, Oct 14, 2024 at 03:02:27PM +0200, Patrick Steinhardt wrote:
Show 33 quoted lines
> Convert the reftable library to use the `reftable_buf` interface instead > of the `strbuf` interface. This is mostly a mechanical change via sed(1) > with some manual fixes where functions for `strbuf` and `reftable_buf` > differ. The converted code does not yet handle allocation failures. This > will be handled in subsequent commits. > > Signed-off-by: Patrick Steinhardt <ps@pks.im> > --- > reftable/basics.c | 2 +- > reftable/basics.h | 3 +- > reftable/block.c | 34 ++++---- > reftable/block.h | 14 ++-- > reftable/blocksource.c | 6 +- > reftable/blocksource.h | 3 +- > reftable/iter.c | 6 +- > reftable/iter.h | 8 +- > reftable/reader.c | 16 ++-- > reftable/record.c | 80 +++++++++---------- > reftable/record.h | 21 ++--- > reftable/stack.c | 120 ++++++++++++++-------------- > reftable/system.h | 1 - > reftable/writer.c | 66 +++++++-------- > reftable/writer.h | 2 +- > t/unit-tests/lib-reftable.c | 4 +- > t/unit-tests/lib-reftable.h | 7 +- > t/unit-tests/t-reftable-basics.c | 16 ++-- > t/unit-tests/t-reftable-block.c | 42 +++++----- > t/unit-tests/t-reftable-merged.c | 26 +++--- > t/unit-tests/t-reftable-reader.c | 8 +- > t/unit-tests/t-reftable-readwrite.c | 92 ++++++++++----------- > t/unit-tests/t-reftable-record.c | 74 ++++++++--------- > t/unit-tests/t-reftable-stack.c | 90 ++++++++++----------- > 24 files changed, 371 insertions(+), 370 deletions(-)
It's an awfully long patch, but was relatively easy to skim visually.
Thanks, Taylor