Re: [PATCH 2/2] read-cache: free hash context in do_write_index()
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Sep 30, 2024, 12:32 UTC
- Message-ID
- <ZvqaRIY1OzOIh1bc@pks.im>
- In-Reply-To
- <b6fe5b3ef7e5f4ac8cc339685d92e3ac39fcb456.1727696424.git.gitgitgadget@gmail.com>
On Mon, Sep 30, 2024 at 11:40:24AM +0000, Derrick Stolee via GitGitGadget wrote:
Show 21 quoted lines
> From: Derrick Stolee <stolee@gmail.com> > > While writing an index, a 'git_hash_ctx' is allocated for hashing the > file contents. This should be freed as the method exits. > > Signed-off-by: Derrick Stolee <stolee@gmail.com> > --- > read-cache.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/read-cache.c b/read-cache.c > index 3c078afadbc..51845c2e611 100644 > --- a/read-cache.c > +++ b/read-cache.c > @@ -3126,6 +3126,7 @@ out: > free_hashfile(f); > strbuf_release(&sb); > free(ieot); > + free(eoie_c); > return ret; > }
Yup, this one looks correct. I've sent out an equivalent patch via [1] a couple hours ago.
Patrick
[1]: https://lore.kernel.org/git/c51f40c5bd0c56967e348363e784222de7884b79.1727687410.git.ps@pks.im/