Re: [PATCH 2/2] read-cache: free hash context in do_write_index()

From: Derrick Stolee <stolee@gmail.com>
Date: Oct 1, 2024, 10:01 UTC
Message-ID: <0f257003-5a8d-4eca-987d-517d9754f1fd@gmail.com>
In-Reply-To: <ZvqaRIY1OzOIh1bc@pks.im>

On 9/30/24 8:32 AM, Patrick Steinhardt wrote:

> On Mon, Sep 30, 2024 at 11:40:24AM +0000, Derrick Stolee via GitGitGadget wrote:
>> From: Derrick Stolee <stolee@gmail.com>

Show 18 quoted lines

>> diff --git a/read-cache.c b/read-cache.c
>> index 3c078afadbc..51845c2e611 100644
>> --- a/read-cache.c
>> +++ b/read-cache.c
>> @@ -3126,6 +3126,7 @@ out:
>>   		free_hashfile(f);
>>   	strbuf_release(&sb);
>>   	free(ieot);
>> +	free(eoie_c);
>>   	return ret;
>>   }
> 
> Yup, this one looks correct. I've sent out an equivalent patch via [1] a
> couple hours ago.
> 
> Patrick
> 
> [1]: https://lore.kernel.org/git/c51f40c5bd0c56967e348363e784222de7884b79.1727687410.git.ps@pks.im/

Sorry for the collision. I had checked when prepping the GGG PR on Friday but forgot to check again before submitting. Your patch is better in substance and context.

Thanks, -Stolee