Re: [PATCH 3/4] ci: use more recent linux32 image

From: Patrick Steinhardt <ps@pks.im>
Date: Sep 12, 2024, 10:41 UTC
Message-ID: <ZuLFPxsDiMB9UBhF@pks.im>
In-Reply-To: <20240912094730.GC589828@coredump.intra.peff.net>

On Thu, Sep 12, 2024 at 05:47:30AM -0400, Jeff King wrote:

Show 15 quoted lines

> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 97f9b06310..db8e8f75a4 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -339,8 +339,8 @@ jobs:
>            image: alpine
>            distro: alpine-latest
>          - jobname: linux32
> -          image: daald/ubuntu32:xenial
> -          distro: ubuntu32-16.04
> +          image: i386/ubuntu:focal
> +          distro: ubuntu32-20.04
>          - jobname: pedantic
>            image: fedora
>            distro: fedora-latest

We could counteract the loss of testing against Ubuntu 16.04 by adding it to GitLab CI instead:

    diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
    index 2589098eff7..80b1668ebeb 100644
    --- a/.gitlab-ci.yml
    +++ b/.gitlab-ci.yml
    @@ -25,6 +25,9 @@ test:linux:
           fi
       parallel:
         matrix:
    +      - jobname: linux-old
    +        image: ubuntu:16.04
    +        CC: gcc
           - jobname: linux-sha256
             image: ubuntu:latest
             CC: clang

I didn't test it, but it should work alright. GitLab doesn't put any additional executables into the container, so it is entirely self contained. Let me know in case you think this is a good idea and I'll run a CI pipeline against this change.

It's not 32 bit, but at least we continue to verify that Git builds against old distros.

Patrick