Re: [PATCH] ci: remove 'Upload failed tests' directories' step from linux32 jobs

From: Jeff King <peff@peff.net>
Date: Sep 12, 2024, 08:00 UTC
Message-ID: <20240912080011.GA556677@coredump.intra.peff.net>
In-Reply-To: <20240912075631.GA11676@coredump.intra.peff.net>

On Thu, Sep 12, 2024 at 03:56:32AM -0400, Jeff King wrote:

Show 15 quoted lines

> > If somebody finds a better solution (i.e., a way to extract trash
> > directories of failed tests', with actions/upload-artifact@v1), that
> > can be added later on top.
> 
> I looked at this a bit last night, but as I didn't come up with any
> useful solution, I refrained from replying. I was going to do a brief
> write-up of all of my dead ends, but after banging my head against the
> wall a bit more, I think I might actually have something. ;)
> 
> I think a better path forward is to figure out how to keep up to date
> with the upload-artifact action for all jobs. The root of the issue is
> that all of the runner images are 64-bit, and the actions aren't
> prepared to run inside a 32-bit container. They're written in javascript
> and ship with their own node.js, but it doesn't work inside the
> container due to dynamic linking issues.

So obviously that other email ended up long and full of details. What I was originally going to say was: "OK, losing artifact uploads for linux32 is not the end of the world, and it is important to unblock CI now."

But I _think_ all of those details I sent add up to a possible patch series. But it probably still makes sense to take your patch here, as it unblocks CI in the short term. And then I can build the bigger fix on top of that (it touches the same spot, but in the end both end up removing that special case).

-Peff