Re: [PATCH 0/6] Improvements for ref storage formats with submodules

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 7, 2024, 13:18 UTC
Message-ID: <ZrN0HNGLtFMhVp-c@tanuki>
In-Reply-To: <cover.1723032100.git.ps@pks.im>

On Wed, Aug 07, 2024 at 02:43:44PM +0200, Patrick Steinhardt wrote:

Show 18 quoted lines

> Hi,
> 
> this small patch series contains some improvements for ref storage
> formats and their interaction with submodules. Notably:
> 
>   - Use the correct format for submodules in situations where the parent
>     repository uses a different ref storage format than the submodule.
> 
>   - Wire up `--ref-format=` for git-submodule(1), such that users can
>     explicitly use a different ref format for their submodules.
> 
>   - Propagate the `--ref-format=` flag of git-clone(1) into submodules
>     when using `--recursive`.
> 
> The first three patches implement improvements for the above three
> issues and introduce tests. The test did hit some memory leaks, which
> get fixed by patches 3 to 6 such that the new test can be marked as leak
> free.

Just got a shower thought that this isn't quite there yet. Most importantly, I think we should default to the ref storage format of the parent submodule both when adding submodules and when cloning a submodule into a preexisting repository.

I'll wait until tomorrow before addressing this though to ideally get some feedback until then.

Patrick