Re: 2.46 submodule breakage

From: Jeppe Øland <joland@gmail.com>
Date: Aug 6, 2024, 13:18 UTC
Message-ID: <CA+osTZX4FBT5za3Nw2Hc=DCNNbFg=xL4b3AhNmN8S2XKb5BXUA@mail.gmail.com>
In-Reply-To: <CA+osTZVApTAMogBDMaPDEVViJHrFT=BOer=Py4fjTvpsifzfKA@mail.gmail.com>

Hi all,

I did a bunch of testing to narrow down the cause:

It is not related to the Windows port - all the testing was done in WSL. It only happens when the clone containing submodules is done with --ref-format=reftable. The commit breaking it is: 129cb1b99d hash: drop (mostly) unused `is_empty_{blob,tree}_sha1()` functions

Regards, -Jeppe

On Mon, Aug 5, 2024 at 1:31 PM Jeppe Øland <joland@gmail.com> wrote:

Show 26 quoted lines

>
> Hi there,
>
> I just upgraded from Git 2.45.2 to Git 2.46 (Git for Windows, but I
> don't think this has anything to do with that), and it seems to have
> broken some submodule stuff for me.
>
> Specifically, when I do a recursive pull, I get the following error
> from one of the submodules:
>     fatal: Unable to find current revision in submodule path 'path/to/sub'
>
> There are other submodules in the repo that work fine.
> The only difference with this one is that it was added using the
> --name option, so internally it's just known as "sub".
>
> Looks like the problem happens in the final pull stage when it executes:
>     git submodule--helper update --recursive --rebase --
>
> A recursive clone with 2.46 works fine, but any subsequent recursive
> pull gives the error.
> So far I haven't been able to fix it, except by downgrading to 2.45.2.
>
> Any ideas?
>
> Regards,
> -Jeppe