Re: [PATCH 5/5] patch-id: tighten code to detect the patch header
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Jul 29, 2024, 12:07 UTC
- Message-ID
- <ZqeGBJrqIrU2A4jl@tanuki>
- In-Reply-To
- <20240621231826.3280338-6-gitster@pobox.com>
On Fri, Jun 21, 2024 at 04:18:26PM -0700, Junio C Hamano wrote:
Show 12 quoted lines
> @@ -196,11 +211,13 @@ static void generate_id_list(unsigned flags)
> struct strbuf line_buf = STRBUF_INIT;
>
> oidclr(&oid);
> + flags |= GOPID_FIND_HEADER;
> while (!feof(stdin)) {
> patchlen = get_one_patchid(&n, &result, &line_buf, flags);
> if (patchlen)
> flush_current_id(&oid, &result);
> oidcpy(&oid, &n);
> + flags &= ~GOPID_FIND_HEADER;
> }I think I'm missing the obvious. But why don't we have to set `GOPID_FIND_HEADER` when we have flushed the current patch ID? Is this because we know that `get_one_patchid()` stops once it finds the next line starting with a commit? Makes me wonder what happens when there is non-diff garbage between patches for which we are about to generate patch IDs.
Patrick