Re: [PATCH 4/5] patch-id: rewrite code that detects the beginning of a patch

From: Patrick Steinhardt <ps@pks.im>
Date: Jul 29, 2024, 12:03 UTC
Message-ID: <ZqeE_GHh1adyK5PM@tanuki>
In-Reply-To: <20240621231826.3280338-5-gitster@pobox.com>

On Fri, Jun 21, 2024 at 04:18:25PM -0700, Junio C Hamano wrote:

Show 7 quoted lines

> The get_one_patchid() function reads input lines until it finds a
> patch header (the line that begins a patch), whose beginning is one
> of:
> 
>  (1) an "<object name>", which is "git diff-tree --stdin" shows;
>  (2) "commit <object name>", which is "git log" shows; or
>  (3) "From <object name>",  which is "git log --format=email" gives.

All of these items should probably say "which is what ...", where "what" is what is missing.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.