Re: [PATCH v1 01/10] packfile: move sizep computation

From: Patrick Steinhardt <ps@pks.im>
Date: Jul 24, 2024, 08:35 UTC
Message-ID: <ZqC835glYpBFAqu8@tanuki>
In-Reply-To: <20240715003519.2671385-2-e@80x24.org>

On Mon, Jul 15, 2024 at 12:35:10AM +0000, Eric Wong wrote:

> From: Jeff King <peff@peff.net>
> 
> This makes the next commit to avoid redundant object info

Starting with "this" without mentioning what "this" is in the commit subject reads a bit weird. I know you mention what you do in the commit title, but we usually use fully self-contained commit messages here.

Show 21 quoted lines

> lookups easier to understand.
> 
> [ew: commit message]
> 
> Signed-off-by: Jeff King <peff@peff.net>
> Signed-off-by: Eric Wong <e@80x24.org>
> ---
>  packfile.c | 35 ++++++++++++++++++-----------------
>  1 file changed, 18 insertions(+), 17 deletions(-)
> 
> diff --git a/packfile.c b/packfile.c
> index 813584646f..e547522e3d 100644
> --- a/packfile.c
> +++ b/packfile.c
> @@ -1527,7 +1527,8 @@ int packed_object_info(struct repository *r, struct packed_git *p,
>  
>  	/*
>  	 * We always get the representation type, but only convert it to
> -	 * a "real" type later if the caller is interested.
> +	 * a "real" type later if the caller is interested. Likewise...
> +	 * tbd.

This comment gets addressed in the next commit, so this should likely not be changed here?

Patrick