Re: [PATCH v1 03/10] packfile: fix off-by-one in content_limit comparison

From: Eric Wong <e@80x24.org>
Date: Jul 26, 2024, 07:43 UTC
Message-ID: <20240726074355.M208461@dcvr>
In-Reply-To: <ZqC86t7YpVhdmLh_@tanuki>

Patrick Steinhardt <ps@pks.im> wrote:

Show 5 quoted lines

> In practice this doesn't really fix a user-visible bug, right? The only
> difference before and after is that we now start to stream contents
> earlier? And that's why we cannot have a test for this.
> 
> If so, I'd recommend to explain this in the commit message.

Right, it's just for consistency with the rest of the code base. Will update the message for v2.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.