Re: [PATCH v3 3/3] run-command: show prepared command
- From
Ian Wienand <iwienand@redhat.com>
- Date
- May 25, 2024, 01:13 UTC
- Message-ID
- <ZlE7LBFkcio2KFoE@fedora19.localdomain>
- In-Reply-To
- <xmqqo78vksk6.fsf@gitster.g>
On Fri, May 24, 2024 at 10:50:33AM -0700, Junio C Hamano wrote:
> > Should I just leave as is? > > If I found as-is would be good enough, I wouldn't have been > commenting on this.
I think this "for ... done" example from me is perhaps too specific and weird, and not being helpful. I'll trim all this out as I think the point can be made clearer.
> Even in this third iteration, I still didn't see the added > documentation talk about the principle behind the design, i.e. what > you write after the "git your-alias" are appended to the command > line to be used as additional arguments.
I'll send an update that makes it clearer in a separate point that for simple arguments, the added "$@" just passes through arguments as additional positional arguments.
-i