Re: [PATCH] alias: document caveats and add trace of prepared command

From: Eric Sunshine <sunshine@sunshineco.com>
Date: May 22, 2024, 03:29 UTC
Message-ID: <CAPig+cSDZzwH5RLYXbUXvdePHUtrPDDEdapQakB22zBkO25kuw@mail.gmail.com>
In-Reply-To: <20240522024133.1108005-1-iwienand@redhat.com>

On Tue, May 21, 2024 at 10:42 PM Ian Wienand <iwienand@redhat.com> wrote:

Show 12 quoted lines

> [...]
> For a "split" alias, e.g. test = "!echo $*" you will see
>
>  $ GIT_TRACE=1 git test hello
>  11:00:45.959420 git.c:755               trace: exec: git-test hello
>  11:00:45.959737 run-command.c:657       trace: run_command: git-test hello
>  11:00:45.961424 run-command.c:657       trace: run_command: 'echo $*' hello
>  11:00:45.961528 run-command.c:437       trace: prepare_cmd: /bin/sh -c 'echo $* "$@"' 'echo $*' hello
>  hello hello
>
> which clearly shows you the appended "$@".  This can be very helpful
> when an alias is giving you an unexpected synatx error that is very

s/synatx/syntax/

> difficult figure out from only the run_command trace point,
> e.g. test = "!for i in 1 2 3; do echo $i; done"
> [...]
> Signed-off-by: Ian Wienand <iwienand@redhat.com>