Re: [PATCH 00/12] Fix various overly aggressive protections in 2.45.1 and friends

From: Joey Hess <id@joeyh.name>
Date: May 22, 2024, 10:01 UTC
Message-ID: <Zk3ChIHr5amGh8Mt@kitenet.net>
In-Reply-To: <20240521195659.870714-1-gitster@pobox.com>

Junio C Hamano wrote:

> As people have seen, the latest "security fix" release turned out to
> be a mixed bag of good vulnerability fixes with a bit over-eager
> "layered defence" that broke real uses cases like git-lfs.

"fsck: warn about symlink pointing inside a gitdir" (a33fea0886cfa016d313d2bd66bdd08615bffbc9) also broke pushing git-annex repositories to eg Gitlab and has several other problems including dodgy PATH_MAX checks that cause new OS interoperability problems. (I posted details to an earlier thread but have now found this current one, oops.)

Please also revert it, or at least the portions for and symlinkPointsToGitDir and symlinkTargetLength. The checks for symlinkTargetBlob and symlinkTargetMissing seem worth keeping.

> Let's quickly get them in working order back first, with the vision that
> we will then rebuild layered defence more carefully in the open on
> top as necessary.

Exellent plan.

-- 
see shy jo