Re: [PATCH 2/5] builtin: stop using `the_index`

From: Patrick Steinhardt <ps@pks.im>
Date: Apr 18, 2024, 12:16 UTC
Message-ID: <ZiEPI-ef8qXD3SqR@tanuki>
In-Reply-To: <CAOLa=ZS2S4=bC=s=vFnSfgvB0jZoKmH2Pi00V1Asyxo_yKSHPA@mail.gmail.com>

On Wed, Apr 17, 2024 at 05:32:50PM +0000, Karthik Nayak wrote:

Show 13 quoted lines

> [snip]
> 
> > diff --git a/builtin/cat-file.c b/builtin/cat-file.c
> > index 0c948f40fb..fe873807ed 100644
> > --- a/builtin/cat-file.c
> > +++ b/builtin/cat-file.c
> > @@ -3,7 +3,6 @@
> >   *
> >   * Copyright (C) Linus Torvalds, 2005
> >   */
> > -#define USE_THE_INDEX_VARIABLE
> 
> Nit: The other changes have a newline after the header.

Good catch.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.