Re: [PATCH 0/5] global: drop external `the_index` variable

From: Karthik Nayak <karthik.188@gmail.com>
Date: Apr 17, 2024, 17:40 UTC
Message-ID: <CAOLa=ZQmCWh_UHJ+JWbzd_b=Ob=gUE=5wEKy3gpaxu=Bru+Wvg@mail.gmail.com>
In-Reply-To: <cover.1713180749.git.ps@pks.im>

Hello,

Patrick Steinhardt <ps@pks.im> writes:

Show 12 quoted lines

> Hi,
>
> this patch series converts remaining users of `the_index` to stop using
> it, instead using `the_repository->index`. This gets rid of one more
> global variable and brings a project over the finish line that has
> started back in 2007.
>
> I realize that this patch series is quite large, and that reviewers will
> eventually start to just gloss over things because the conversions are
> kind of boring, too. Also, due to the size it's quite likely to conflict
> with in-flight topics. So if you think that this is too large, please
> let me know and I will happily split this up into multiple series.

I gave it a glance review. I also wanted to run the tests on each commit, but couldn't apply the series cleanly on either master or next.