Re: [PATCH v2 08/11] reftable/writer: unify releasing memory
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Apr 4, 2024, 11:43 UTC
- Message-ID
- <Zg6SVcGC8kSGSYh-@tanuki>
- In-Reply-To
- <CAOw_e7a9BnEh2OatwaGoSyVK46Wv2-sVkArbtXHLPt79b6g2qQ@mail.gmail.com>
On Thu, Apr 04, 2024 at 11:00:46AM +0200, Han-Wen Nienhuys wrote:
> On Thu, Apr 4, 2024 at 9:32 AM Patrick Steinhardt <ps@pks.im> wrote: > > On Thu, Apr 04, 2024 at 09:08:46AM +0200, Han-Wen Nienhuys wrote:
[snip]
Show 7 quoted lines
> > It might not be the cleanest way to handle this, but I think this patch > > is an improvement over the previous state because we plug a memory leak > > and deduplicate the cleanup logic. So I would suggest to defer your > > proposed refactorings to a later point, if you're okay with that. > > yes. Please add reftable_writer_release to reftable-writer.h for > consistency, though. Or remove the reftable_ prefix.
I've dropped the `reftable_` prefix locally. Will wait a bit for additional reviews though before sending out v3.
Patrick