Re: [PATCH v2 06/11] reftable/writer: refactorings for `writer_add_record()`

From: Han-Wen Nienhuys <hanwenn@gmail.com>
Date: Apr 4, 2024, 06:58 UTC
Message-ID: <CAOw_e7YeqEK4O=KWowMYGtRVMLwL3y6bWw2LRfC9TqJz06Esyg@mail.gmail.com>
In-Reply-To: <4877ab39212867e91058c60f99fe0dc2a592d583.1712209149.git.ps@pks.im>

On Thu, Apr 4, 2024 at 7:48 AM Patrick Steinhardt <ps@pks.im> wrote:

Show 8 quoted lines

> +       /*
> +        * Try to add the record to the writer again. If this still fails then
> +        * the record does not fit into the block size.
> +        *
> +        * TODO: it would be great to have `block_writer_add()` return proper
> +        *       error codes so that we don't have to second-guess the failure
> +        *       mode here.
> +        */

The Go code returns a (size, boolean) tuple for the write routines here, but that does not really work in the Git C style.

If you make the routines return error codes it suggests that the in-memory write can fail for other reasons beyond "does not fit". Not sure if that is really an improvement.

-- 
Han-Wen Nienhuys - hanwenn@gmail.com - http://www.xs4all.nl/~hanwen