Re: [PATCH v2 1/1] config: learn the "hostname:" includeIf condition

From: Taylor Blau <me@ttaylorr.com>
Date: Mar 16, 2024, 16:01 UTC
Message-ID: <ZfXCXAdlYdS/p8BC@nand.local>
In-Reply-To: <20240309181828.45496-2-ignacio@iencinas.com>

Hi Ignacio,

On Sat, Mar 09, 2024 at 07:18:28PM +0100, Ignacio Encinas wrote:

Show 5 quoted lines

> ---
>  Documentation/config.txt  |  9 +++++++++
>  config.c                  | 17 ++++++++++++++++
>  t/t1305-config-include.sh | 42 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 68 insertions(+)

I took a look at this patch and felt that it was all very sensible. I left one comment in reply to the sub-thread with you and Peff with some minor suggestions on the documentation.

Otherwise, the code changes here all look reasonable to me.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.