Re: [PATCH v3 0/2] Add hostname condition to includeIf
- From
Chris Torek <chris.torek@gmail.com>
- Date
- Mar 20, 2024, 14:34 UTC
- Message-ID
- <CAPx1GvcVZgsU+WHecLd8PWo_MN+wJj6wQ-G5nxYvWnOUOhfQng@mail.gmail.com>
- In-Reply-To
- <CAPig+cS_hCOnAuwRd_dY5h37-wgHCk2tjS7asm2Dm_p=s41X3Q@mail.gmail.com>
The suggestion for having `git var` list GIT_HOSTNAME gave me an idea: perhaps instead of, or in addition to, a `hostname` condition in the `includeif` code, we could:
* have an `includeif:env:...` condition that tests an env variable against a pattern; and/or * use $GIT_HOSTNAME as the variable.
We'd then set `GIT_HOSTNAME` to the gethostname() result *unless* it's already set.
This gives users much more flexibility, because:
* they can use the hostname and/or arbitrary-env-var condition; * they can then *set* GIT_HOSTNAME to the short or full hostname at their discretion if the default is not suitable for some reason; and of course * they can, as noted, use `git var` to find the default setting.
Chris