Re: [PATCH v3 0/5] completion: improvements for git-bisect

From: Patrick Steinhardt <ps@pks.im>
Date: Jan 19, 2024, 07:05 UTC
Message-ID: <ZaofJhHsFjRxx7a3@tanuki>
In-Reply-To: <20240118204323.1113859-1-britton.kerin@gmail.com>

On Thu, Jan 18, 2024 at 11:43:18AM -0900, Britton Leo Kerin wrote:

Show 5 quoted lines

> CC to add: CC: Junio C Hamano <gitster@pobox.com>, Patrick Steinhardt <ps@pks.im>
> 
> Relative to v2 this only changes a wrong misleading commit message.
> 
> Bring completion for bisect up to date with current features.

Thanks for your patches! I've got a few comments to bring them more in line with how we're doing things in the Git project, but I agree with the overall direction that they are going into.

It might be a good idea to also add a few tests in t9902-completion.sh to ensure that the newly introduced completions work as expected.

Thanks!

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.