Re: [PATCH v3 0/5] completion: improvements for git-bisect
- From
Britton Kerin <britton.kerin@gmail.com>
- Date
- Jan 26, 2024, 00:23 UTC
- Message-ID
- <CAC4O8c9qe2CNv2aHLwDBS9WaME=2DDje+QWq3T-OmxC5wAbw8g@mail.gmail.com>
- In-Reply-To
- <ZaofJhHsFjRxx7a3@tanuki>
On Thu, Jan 18, 2024 at 10:05 PM Patrick Steinhardt <ps@pks.im> wrote:
Show 14 quoted lines
> > On Thu, Jan 18, 2024 at 11:43:18AM -0900, Britton Leo Kerin wrote: > > CC to add: CC: Junio C Hamano <gitster@pobox.com>, Patrick Steinhardt <ps@pks.im> > > > > Relative to v2 this only changes a wrong misleading commit message. > > > > Bring completion for bisect up to date with current features. > > Thanks for your patches! I've got a few comments to bring them more in > line with how we're doing things in the Git project, but I agree with > the overall direction that they are going into. > > It might be a good idea to also add a few tests in t9902-completion.sh > to ensure that the newly introduced completions work as expected.
Thanks for the review, other than the one philosophical issue about how functions should be introduced/moved I agree with everything you said and will rework the series accordingly.
Britton