Re: [PATCH] rebase: clarify --reschedule-failed-exec default

From: Taylor Blau <me@ttaylorr.com>
Date: Jan 4, 2024, 19:20 UTC
Message-ID: <ZZcE/Kw24YKlqSOT@nand.local>
In-Reply-To: <20240104080631.3666413-1-illia.bobyr@gmail.com>

On Thu, Jan 04, 2024 at 12:06:31AM -0800, Illia Bobyr wrote:

Show 5 quoted lines

> Documentation should mention the default behavior.
>
> It is better to explain the persistent nature of the
> --reschedule-failed-exec flag from the user standpoint, rather than from
> the implementation standpoint.

The first paragraph looks good, and I think your wording is an improvement over what's already there (though of course this is subjective, and YMMV).

Show 5 quoted lines

> +Recording this option for the whole rebase is a convenience feature. Otherwise
> +an explicit `--no-reschedule-failed-exec` at the start would be overridden by
> +the presence of a `rebase.rescheduleFailedExec=true` configuration when `git
> +rebase --continue` is invoked. Currently, you can not, pass
> +`--[no-]reschedule-failed-exec` to `git rebase --continue`.

The last sentence was a bit confusing to me. I assume you meant

    Currently, you cannot pass `--[no-]reschedule-failed-exec` [...]

without the comma between "pass" and "`--[no]reschedule-failed-exect`", and replacing "can not" with "cannot".

Thanks, Taylor